NREL / electrolyzer

Other
20 stars 15 forks source link

Fix/deg rates #30

Closed ZackTully closed 1 year ago

ZackTully commented 1 year ago

resolves #27

Ready to be merged Tests pass

Feature or improvement description The degradation rates in stack.py were updated to better match experimental results from degradation literature. The degradation tests in test_stack.py were updated to reflect the change in rates.

Related issue, if one exists

27

Impacted areas of the software

Additional supporting information

Test results, if applicable

References for degradation rates:

  1. S. M. Alia, S. Stariha, and R. L. Borup, “Electrolyzer Durability at Low Catalyst Loading and with Dynamic Operation,” J. Electrochem. Soc., vol. 166, no. 15, pp. F1164–F1172, 2019, doi: 10.1149/2.0231915jes.
  2. A. Weiß, A. Siebel, M. Bernt, T.-H. Shen, V. Tileli, and H. A. Gasteiger, “Impact of Intermittent Operation on Lifetime and Performance of a PEM Water Electrolyzer,” J. Electrochem. Soc., vol. 166, no. 8, pp. F487–F497, 2019, doi: 10.1149/2.0421908jes.
camirmas commented 1 year ago

@ZackTully if you are comfortable with the changes, go ahead and update that failing regression test. It is intended to fail for model changes, so as long as it's failing in the way we expect, we can update it to match the new results

ZackTully commented 1 year ago

@camirmas Okay. I changed the test_regression test to pass with the updated degradation rates. I also change the imports in tests/glue_code/test_run_electrolyzer.py from from electrolyzer import Supervisor, run_electrolyzer to from electrolyzer import Supervisor from electrolyzer.glue_code.run_electrolyzer import run_electrolyzer.