Closed ZackTully closed 1 year ago
@ZackTully if you are comfortable with the changes, go ahead and update that failing regression test. It is intended to fail for model changes, so as long as it's failing in the way we expect, we can update it to match the new results
@camirmas Okay. I changed the test_regression
test to pass with the updated degradation rates. I also change the imports in tests/glue_code/test_run_electrolyzer.py
from
from electrolyzer import Supervisor, run_electrolyzer
to
from electrolyzer import Supervisor
from electrolyzer.glue_code.run_electrolyzer import run_electrolyzer
.
resolves #27
Ready to be merged Tests pass
Feature or improvement description The degradation rates in
stack.py
were updated to better match experimental results from degradation literature. The degradation tests intest_stack.py
were updated to reflect the change in rates.Related issue, if one exists
27
Impacted areas of the software
electrolyzer/stack.py
tests/test_stack.py
Additional supporting information
Test results, if applicable
References for degradation rates: