NREL / electrolyzer

Other
20 stars 15 forks source link

Feature/decision ctrl #43

Closed ZackTully closed 1 year ago

ZackTully commented 1 year ago

Ready to be merged Tests expected to pass

Feature or improvement description New controller type in Supervisor: decision control. Decision control makes four decisions: whether to turn stacks on, whether to turn stacks off, which order to switch stacks on and off, and how to distribute power amongst active stacks. It makes each decision according to one of two policies.

Related issue, if one exists none

Impacted areas of the software Supervisor.py and Stack.py are the only files with serious changes.

Additional supporting information Some of the existing controller options in Supervisor.py are equivalent to decision control with the right set of policies. These redundant controllers will be removed eventually.

camirmas commented 1 year ago

Looks good to me! Would you mind opening an issue for the redundant controllers, so we can track it in case we don't get to it right away?

ZackTully commented 1 year ago

Not passing test_run_lcoh test. Values are close but not quite equal.

camirmas commented 1 year ago

@ZackTully the LCOH test is broken on develop at the moment. I updated it to match in my PR #48 with Elenya reviewing. So if you're comfortable with your changes then go ahead and merge without that test passing

camirmas commented 1 year ago

@ZackTully if you pull develop now the tests should pass