NREL / electrolyzer

Other
20 stars 15 forks source link

Issue #61: Update Cathod Pressure to be 30bar #66

Closed nRiccobo closed 12 months ago

nRiccobo commented 1 year ago

Issue #63: Nernst equation was incorrect. This issue only became became apparent when adjusting cathode pressure.

Yes. All tests have been updated and pass. However, we really should look at splitting up some of the tests like run_electrolyzer and run_lcoh that are so dependent on small changes to the model.

Feature or improvement description Addressed the bug #63 issue. Fixed the partial pressure calculations within the cell.py script.

Impacted areas of the software Calculations to LCOH and hydrogen output will be slightly different due to the different cell voltage and thus current density.

nRiccobo commented 1 year ago

Strange. It failed the test_run_lcoh.py, but I was certain that I added and committed the updated values to make it pass the test.

nRiccobo commented 1 year ago

There was a change that I committed, but did not push to my fork prior to the pull request. Now it should have passed everything.