NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
32 stars 18 forks source link

Feature/add timing funcs #101

Closed paulf81 closed 1 year ago

paulf81 commented 1 year ago

Might be ready to merge, depends if we want to try incrementally

Feature or improvement description Before starting the final polars port process, I thought it was important to have a consistent way to benchmark timing of operations, to be sure if we're helping/hurting, once accounting for back and forth from polars. @rafmudaf shared a small repo he uses to accomplish this for FLORIS: https://github.com/rafmudaf/floris_metrics

And I have adapted this for flasc: https://github.com/paulf81/flasc_metrics

Because this works by comparing matching functions across commits, I thought it would be helpful if I generated a set of functions whose API will be consistent from the timing functions perspective, even if we change for example how the energy ratio is called a little bit in the new polars frame. That is the reason for the new timing_tests folder. I think as we consider improving functions for speed (or maybe memory someday) we can build on this interface.

paulf81 commented 1 year ago

hi @Bartdoekemeijer @rafmudaf and @misi9170 breaking convention a little bit and merging without approval to try to keep the sprint cruising along, but since this really only adds a file and doesn't modify anything I think should be ok