NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
31 stars 18 forks source link

[Enhancement] Reorganize artifical data examples to make them easier to follow #117

Closed misi9170 closed 1 year ago

misi9170 commented 1 year ago

Ready for review and possible merge.

Feature or improvement description Some reorganization of the examples was needed for clarity. In particular,

  1. A subdirectory names examples/ still existed under the flasc/ source code directory, which contained example input files and a utility for loading them but no example code.
  2. The artificial_data examples were not clearly laid out

These have now been addressed by

  1. Moving models.py up to flasc/ and renaming it utiltiesexamples.py and moving the example input files to their respective examples directories (examples_smarteole/ and examples_artifical_data/)
  2. Numbering the subdirectories and files within the subdirectories of examples_artifical_data/

Related issue, if one exists

113

Impacted areas of the software examples_artifical_data/, examples_smarteole/, flasc (to a small extent)

Aditional notes

Test results, if applicable Test pass after polars update

paulf81 commented 1 year ago

Modified the description to include the small polars bugfix