search

NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
31 stars 18 forks source link

Change nan behavior #121

Closed paulf81 closed 1 year ago

paulf81 commented 1 year ago

Ready to be merged (maybe can delete some commented out lines)

Feature or improvement description This pull request address Issue #119 , where we inadvertently changed nan filtering from an "Any" to an "All" in the conversion of energy ratio from pandas to polars. This pull requests fixes the convention back, and adds a test to confirm the expected behavior (and check going forward)

Related issue, if one exists

119

Impacted areas of the software energy_ratio.py energy_ratio_output.py energy_ratio_utiltities.py energy_ratio_test.py

paulf81 commented 1 year ago

@misi9170 good to merge?

misi9170 commented 1 year ago

@misi9170 good to merge?

@paulf81 I've made some updates here based around allowing users to choose whether to use "all" or "any" behavior. In doing so, I decided to move the filtering steps to utilities.

I also made an unrelated to change to have the process of checking inputs to compute_energy_ratio() happen in a separate utility for ease of reading. Feel free to revert that if you disagree.

paulf81 commented 1 year ago

Looks great @misi9170, thank you! Merging