[BUG] Model Estimation and Model Tuning modules seem similar

NREL / flasc

A rich floris-driven suite for SCADA analysis

https://nrel.github.io/flasc/

BSD 3-Clause "New" or "Revised" License

30 stars 18 forks source link

[BUG] Model Estimation and Model Tuning modules seem similar #144

Closed paulf81 closed 4 months ago

paulf81 commented 8 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Model estimation and model tuning modules in FLASC have different functionality, but are notionally related, should probably be harmonized into one module in the future

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- pip environment (can be retrieved with `pip list`):

Anything else?

No response

misi9170 commented 8 months ago

Agreed, we could use some alignment here, possibly as part of a larger restructuring. Another one to toss in as relevant, but in a separate location yaw_pow_fitting.py

paulf81 commented 8 months ago

Yeah, seems like these could all be combined into one cohesive module as an upcoming activity

Bartdoekemeijer commented 8 months ago

Sounds like a great idea!

misi9170 commented 4 months ago

Addressed in #165