Closed paulf81 closed 8 months ago
Nice! On your points above:
np.random.seed(0)
right after if __name__ == "__main__":
for reproducibilityplt.show()
off? There are a lot of plots made in this script that are abandonedplot_binned_mean_and_ci
call, so if you don't want to plot anything anyway that line can be commented out and the warnings don't appear. On the other hand, it's probably best to track those down and see what causes them?EDIT: I've now fixed the warnings, I think. In doing so, I made the following changes:
x_edges
passed to plot_binned_mean_and_ci()
, which avoids empty bins caused by default edgesplot_binned_mean_and_ci()
, which is possibly not needed for realistic data but avoids warnings raised with the synthetic data that is too uniformThis fixes all warnings that I was seeing.
Thanks @misi9170 ! I know you're making some last checks but feel free to merge when done, thank you!
Feature or improvement description This pull request adds an additional example demonstrating the calculation of total uplift. I think it's mostly ready but there are a few finer points I'd like to work through before merging:
Related issue, if one exists Closes Issue #138