NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
30 stars 18 forks source link

Feature/add uplift example #155

Closed paulf81 closed 8 months ago

paulf81 commented 8 months ago

Feature or improvement description This pull request adds an additional example demonstrating the calculation of total uplift. I think it's mostly ready but there are a few finer points I'd like to work through before merging:

Related issue, if one exists Closes Issue #138

misi9170 commented 8 months ago

Nice! On your points above:

EDIT: I've now fixed the warnings, I think. In doing so, I made the following changes:

This fixes all warnings that I was seeing.

paulf81 commented 8 months ago

Thanks @misi9170 ! I know you're making some last checks but feel free to merge when done, thank you!