search

NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
30 stars 18 forks source link

Basic Floris v4 compatibility #169

Closed misi9170 closed 6 months ago

misi9170 commented 6 months ago

FLASC v2 will be released with FLORIS v4. This pull request ensures that, at this time, the v2 branch of FLASC is consistent with FLORIS v4 (still in development). Further fixes may be needed as FLORIS v4 is developed. Also, this PR only implements basic consistency---new features of FLORIS v4 are not exploited, but I have called out places that can likely exploit new functionalities (to be addressed in a separate PR), especially calc_floris_approx_table() in flasc/utilities/floris_tools.py.

Fixes the failing tests created by #165

I've also updated the example inputs. Note that FLORIS's ParallelComputingInterface is yet to be updated for FLORIS v4, so I've opted to use the FlorisInterface instead when creating approximate FLORIS solutions. However, this appears to be fast, so the ParallelComputingInterface may not be needed?

Checklist

Exceptions

paulf81 commented 6 months ago

I'm running through the examples now and finding little things to fix here and there, but wanted to flag a few things:

1) I'm realizing flasc is under-tested, too many examples are failing despite passing tests, something for future work 2) The examples in examples_artificial_data/02_wake_steering_design, I might wait to fix until the relavent optimization improvements are in floris v4

paulf81 commented 6 months ago

Adding to previous list of things to revisit:

  1. I'm realizing flasc is under-tested, too many examples are failing despite passing tests, something for future work

  2. The examples in examples_artificial_data/02_wake_steering_design, I might wait to fix until the relavent optimization improvements are in floris v4

  3. the linear interp in plot_layout in energy_ratio_het...mapper.py is failing in example 05

paulf81 commented 6 months ago

Ok @misi9170 I think (almost) all the examples are now updated to FLORIS v4. The ones with remaining issues I put seperate tracking issues for:

Issue #170 Issue #171

This one is good to merge from my perspective now