search

NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
30 stars 18 forks source link

Add logging to FLASC #172

Closed paulf81 closed 4 months ago

paulf81 commented 6 months ago

Draft for now

Feature or improvement description This pull request starts the process of converting from print, and the custom function printnow, to using python's logging modules. The code is based on FLORIS' implementation with a central logging_manager.py, however it has been somewhat refactored for FLASC:

1) Because there isn't a central FLASC object like there is for FLORIS, couldn't rely on external code to call the logging configuration functions with the input yaml instructions like you can with FLORIS, so the configuration is instead done by the LoggingManager class at init based on passed inputs 2) Based on printnow function, assumed the desired default formatting includes the timestamp

There's not too much left to do, but was curious to see what you think @misi9170 and @Bartdoekemeijer before going to much further. If you want to see what it looks like, example examples_artificial_data/01_raw_data_processing/01_northing_calibration.ipynb has logging outputs in it Related issue, if one exists

135

Bartdoekemeijer commented 6 months ago

I like this, will definitely streamline and professionalize FLASC!