NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
32 stars 18 forks source link

[BUG] Failing tests due to pandas pd.concat #21

Closed bayc closed 2 years ago

bayc commented 2 years ago

Is there an existing issue for this?

Current Behavior

The test df_time_operations.py is failing due to type errors. The issue has been traced to a pd.concat call in time_operations.py where a column is trying to be added, but instead, rows are added with the column.

Expected Behavior

The test should pass.

Steps To Reproduce

Run pytest df_time_operations.py in the tests directory.

Environment

- OS: Ubuntu 20.04
- pip environment (can be retrieved with `pip list`):
  - pandas 1.4.4
  - numpy 1.21.5
  - scipy 1.8.0

Anything else?

None.

misi9170 commented 2 years ago

This seems to be at least partly due to the new version of pandas. Looking into this now.

misi9170 commented 2 years ago

Have submitted pull request for review on this issue.

paulf81 commented 2 years ago

Resolved by pull request #23