search

NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
31 stars 18 forks source link

Enforce user to specify ti #26

Closed Bartdoekemeijer closed 1 year ago

Bartdoekemeijer commented 1 year ago

Feature or improvement description Improvement / clarifying usage of floris_tools functions. FLORIS solutions are typically calculated inside FLASC by first calculating a large set of solutions over a grid (wind direction, wind speed and sometimes turbulence intensity). Then, the FLORIS solutions during FLASC operations are found quickly by interpolating over this precalculated grid. However, this grid does not always cover all relevant conditions, and often it is unclear which turbulence intensity is really assumed when interpolating from the precalculated solutions. This change forces users to manually specify the turbulence intensity assumed by FLORIS for the SCADA data.

Related issue, if one exists N/A

Impacted areas of the software floris_tools

Additional supporting information N/A

Test results, if applicable N/A

Bartdoekemeijer commented 1 year ago

Hi @misi9170 and @paulf81. This PR is a small one but wanted to get attention on it again. It forces the user to specify the turbulence intensity in df rather than assuming its the same as the value in floris. This just avoids ambiguity and ensures the user knows what assumption is made before proceeding with the analysis. Also, this PR removes calc_floris since it's really outdated, as far as I can see. I think we may at some point want to reimplement calc_floris with the ParallelComputingInterface class and usage of the timeseries function in FlorisInterface, but I haven't found a need for it currently.

Bartdoekemeijer commented 1 year ago

Also I've just merged in the latest develop branch and resolved any conflicts. Good to merge on my side.

misi9170 commented 1 year ago

@Bartdoekemeijer I've now approved your changes. Just checking you're happy before I go ahead and merge.

Bartdoekemeijer commented 1 year ago

Great, merging!

paulf81 commented 1 year ago

Thanks @Bartdoekemeijer !