search

NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
32 stars 18 forks source link

Make labeling UQ optional in energy ratio plot #30

Closed paulf81 closed 2 years ago

paulf81 commented 2 years ago

Is ready to be merged

Feature or improvement description Make labeling UQ optional in energy ratio plot, with default set to False

Related issue, if one exists Issue #29

codecov-commenter commented 2 years ago

Codecov Report

Base: 34.60% // Head: 34.58% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (2040fe9) compared to base (7f01b0e). Patch coverage: 37.50% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #30 +/- ## =========================================== - Coverage 34.60% 34.58% -0.02% =========================================== Files 38 38 Lines 3627 3629 +2 =========================================== Hits 1255 1255 - Misses 2372 2374 +2 ``` | [Impacted Files](https://codecov.io/gh/NREL/flasc/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [flasc/energy\_ratio/energy\_ratio\_suite.py](https://codecov.io/gh/NREL/flasc/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-Zmxhc2MvZW5lcmd5X3JhdGlvL2VuZXJneV9yYXRpb19zdWl0ZS5weQ==) | `10.25% <33.33%> (ø)` | | | [flasc/energy\_ratio/energy\_ratio\_visualization.py](https://codecov.io/gh/NREL/flasc/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-Zmxhc2MvZW5lcmd5X3JhdGlvL2VuZXJneV9yYXRpb192aXN1YWxpemF0aW9uLnB5) | `3.15% <33.33%> (-0.03%)` | :arrow_down: | | [flasc/energy\_ratio/energy\_ratio.py](https://codecov.io/gh/NREL/flasc/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-Zmxhc2MvZW5lcmd5X3JhdGlvL2VuZXJneV9yYXRpby5weQ==) | `65.91% <50.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

paulf81 commented 2 years ago

Good suggestions @Bartdoekemeijer I took both of them, thank you!

paulf81 commented 2 years ago

@Bartdoekemeijer made one additional change of including the boolean option in the high-level calling functions and passing them through, using same name and doc string, let me know if this looks ready to go