NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
32 stars 18 forks source link

Seperate layout visualization and power/thrust curve plots #32

Closed misi9170 closed 2 years ago

misi9170 commented 2 years ago

Breaking out the power and thrust curve plots form the layout plot to provide users with more flexibility. plot_floris_layout retains default behavior, but calls lower level functions. Also now allows for no labels to be printed on the layout plot (but providing turbine_names=[] to plot_floris_layout.

paulf81 commented 2 years ago

I think this is a big improvement @misi9170, thank you! I confirm I downloaded the code and ran examples that call the new split up functionality and it ran fine

I think though we could add just a little more to this pull request (I can help) my ideas our:

paulf81 commented 2 years ago

Just wanting to connect this with project board and issue #34

misi9170 commented 2 years ago

@paulf81 Sounds good, I'll work on incorporating those and creating an example.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@d1adcd3). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head 3b5b98b differs from pull request most recent head 8e29892. Consider uploading reports for the commit 8e29892 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #32 +/- ## ========================================== Coverage ? 33.88% ========================================== Files ? 38 Lines ? 3736 Branches ? 0 ========================================== Hits ? 1266 Misses ? 2470 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

misi9170 commented 2 years ago

@paulf81 I've now updated this to incorporate a wake distances/directions plot and plots for yaw offset schedules. Both can be viewed by running examples/wake_steering_design/00_analyze_single_ws_v_range.py. I believe this is now ready to be merged.

paulf81 commented 2 years ago

Merged!