NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
32 stars 18 forks source link

catch case of small number of points #54

Closed paulf81 closed 1 year ago

paulf81 commented 1 year ago

Yes

Feature or improvement description Add check for small number of points in block bootstrapping (less than number of blocks) and in that case revert to using each point as block

misi9170 commented 1 year ago

This looks good to me. Any chance you want to print a warning if this happens so that the user is notified that something will be different? E.g.

if num_blocks > df_binned.shape[0]:
            num_blocks = df_binned.shape[0]
            print("Warning: num_blocks reduced to match the length of the df_binned.")
paulf81 commented 1 year ago

I think not because it will get spammy, I was thinking at first this would be rare but once I started using it realized that there's always the wind direction bin / controller combination that is light on data

paulf81 commented 1 year ago

Done, thanks @misi9170 !