Closed misi9170 closed 1 year ago
This goes back to commit 5d23e3b3, when the approach of calc_floris_approx_table
changed away from calling calc_floris
(which does use parallelization)
Good catch @misi9170! Your PR looks good to me. Also, two more comments:
calc_floris_approx_table
with parallelization by just inserting a ParallelComputingInterface FLORIS object instead of a FlorisInterface object into it. See https://github.com/NREL/floris/pull/555 on the FLORIS repository. (I generally am really happy with how this ParallelComputingInterface class is working out -- it really just swaps out with a FlorisInterface
object and then performs everything in parallel in the background.)calc_floris
function since I don't use it anywhere in my code, currently.Thank you @misi9170 and @Bartdoekemeijer !
@Bartdoekemeijer Thanks, that's a good hint on the parallel computing FLORIS interface and sounds good regarding possible deprecation of calc_floris
.
Squashing and merging.
Problem:
In examples/raw_data_processing/a_07a... and a_08..., there are calls to
calc_floris_approx_table
(from flasc/floris_tools.py) that are passed invalid keyword argumentsnum_workers
andnum_threads
. This may have been from a previous implementation ofcalc_floris_approx_table
that had or was intended to have parallel computing capabilities.Steps to reproduce:
Solution:
I've removed the invalid keyword arguments from the call. The code now runs as expected.