Closed Bartdoekemeijer closed 1 year ago
Yes let's do that! There might be a couple more bugs that I haven't found yet though. I'm working on FLASC a lot over the next 2 weeks. Is it OK if we keep this PR open until then? That way I can add on as I find more bugs.
Yes let's do that! There might be a couple more bugs that I haven't found yet though. I'm working on FLASC a lot over the next 2 weeks. Is it OK if we keep this PR open until then? That way I can add on as I find more bugs.
Sounds good to me! I will also be tinkering (polars and database stuff), I just caught my polars pull up to yours and will try to keep up
Sorry I had made an absolute mess mixing up some PRs here. Restored it with a force push.
In the most recent commit, I vectorized some code that was previously in a for
loop. This helped speed up the part where we calculate the histogram/median power curve based on the data. Additionally, I have reduced the calls to this function to save time, and only call it when it's actually needed. The ws_pow_filtering
code now runs about a factor 5 times faster on my machine.
OK to merge into main
if you ask me! Any future bug fixes, I'll open a new PR for.
Just committed the PyPI bug fix from @rafmudaf.
@rafmudaf do you approve merging? If so you can either merge or let me know and I'll do it, thanks!!
@paulf81 Yes, from the perspective of the setup.py
infrastructure, this is good to go.
Merged!
This PR is not yet ready to be merged.
Feature or improvement description Various bug fixes throughout the code.
Related issue, if one exists I found various issues running FLASC for wind farm SCADA analyses.
Impacted areas of the software Various
Additional supporting information
Test results, if applicable