search

NREL / flasc

A rich floris-driven suite for SCADA analysis
https://nrel.github.io/flasc/
BSD 3-Clause "New" or "Revised" License
32 stars 18 forks source link

replace append with concat #91

Closed paulf81 closed 1 year ago

paulf81 commented 1 year ago

Elizabeth found a bug in FLASC that if you install now, pandas 2.0 is installed, and it no longer supports the append statement. This causes an error in the example: flasc/examples_smarteole/05_baseline_energy_ratio_analysis.ipynb

This bugfix resolves the issue by replacing the deprecated append, with concat

misi9170 commented 1 year ago

I'm looking through FLASC now and correcting other pandas appends; will push up when complete.

Bartdoekemeijer commented 1 year ago

Perhaps there should be a separate PR on upgrading to Pandas 2.0? Also, I did replace a bunch of append statements in #86.

misi9170 commented 1 year ago

Perhaps there should be a separate PR on upgrading to Pandas 2.0? Also, I did replace a bunch of append statements in #86.

Thanks for pointing that out Bart! Agreed; let's see what @paulf81 would like to do.

paulf81 commented 1 year ago

That works for me too, I was mainly hoping to "hotfix" this one since without the correction some of the smarteole examples have errors, but can also do all at once? Do we think we could bang this out quick?

Bartdoekemeijer commented 1 year ago

Should be resolved by #86 and #96. Please reopen if the error persists.