NREL / floorspace.js

Other
68 stars 36 forks source link

Property defaults/constraints/units #228

Closed shorowit closed 6 years ago

shorowit commented 6 years ago

Many object properties default to 0 or null, whereas they really should be > 0. I suggest we use values from the first example object in the default_library.json. So:

Window Definition:

Daylighting Control:

Pitched Roof:

For Story, I recommend:

Here is the list of properties that the editor should not allow to be <= 0:

I also noticed that new Pitched Roof objects are not being assigned a new color, as is the case for stories, thermal zones, etc.

Finally, we should really label units for the properties. For example:

shorowit commented 6 years ago

The defaults should probably also be in the schema, according to @macumber.

bgschiller commented 6 years ago

Read these from the Schema