search

NREL / floorspace.js

Other
66 stars 35 forks source link

Export fail due to some unknown internal limits #341

Closed fsudaman closed 5 years ago

fsudaman commented 5 years ago

Floorspace appears to have a limit to how large a file can be, after which it can’t be exported (/saved). This is mostly a problem when you import images for various floors, as saving/reloading requires you to delete your images and replace them. Image import is quite manual, and you have to resize by eye, so this is both inconvenient and can cause errors.

The attached JSON file contains a half-built model geometry, in which drawing any new spaces prevents the model from being exported (“Download failed – Network error”). This was tested across multiple machines, in chrome. However, removing the image allows the model to be successfully exported. This issue may be linked to the size of the file, as replacing some of the more complex spaces with simpler ones allows more spaces to be created before hitting the limit.

Export Bug.zip

bgschiller commented 5 years ago

Thanks for the report, and the test case. It looks like we're running up against Chrome's 2mb limit for download URLs ( described at https://craignicol.wordpress.com/2016/07/19/excellent-export-and-the-chrome-url-limit/)

That same post describes a solution that doesn't look too tricky.

bgschiller commented 5 years ago

This has been implemented and works with the test case you provided.

fsudaman commented 5 years ago

Brilliant. Thanks Brian.