search

NREL / floorspace.js

Other
66 stars 35 forks source link

Window Deletion Bug #355

Closed Mkellyeng closed 3 years ago

Mkellyeng commented 5 years ago

If you delete a space that has a window, by using the delete button, you cannot draw any new spaces on that floor.

It appears using the delete button to delete a space doesn't remove windows that are associated with that space, leaving them with a dangling reference.

This results in very strange behaviour that prevents you from drawing any new spaces on that floor. The drawing tools behave as though you're using 'Polygon' (regardless of whether you have rectangle or polygon selected), but you can't accept the shape, finalising the space.

This behaviour is only seen on the floor where the bug was triggered, other floors still behaviour as normal. Saving the file and re-opening retains the bug, but saving, manually removing the window, and re-opening, removes the bug.

See the attached zip file for examples of both the bugged and fixed state

Window Deletion Bug.zip Window Deletion Bug

bgschiller commented 5 years ago

Hi @Mkellyeng, A couple other people have noticed this same problem! I think we have a patch for it over in #356 , but some of the (unrelated) tests are failing. I'm hoping to find time soon to fix up those tests so I can merge the branch in.

bgschiller commented 3 years ago

Closing, as I believe this is fixed now that #356 is merged.

Mkellyeng commented 3 years ago

@bgschiller was this fix only for the open studio version? I can still replicate in the online version image

kylem038 commented 3 years ago

@Mkellyeng I've tested this out on the webapp and it appears to have been resolved. Let us know if you're still able to recreate it.

Mkellyeng commented 3 years ago

Re-tested, Issue is resolved! Fantastic!