Resolution for the Internal ID bug

NREL / floorspace.js

Other

66 stars 35 forks source link

Resolution for the Internal ID bug #379

Closed Mkellyeng closed 3 years ago

Mkellyeng commented 3 years ago

Make "largestID" sum with "v" (int) rather than concatenate (str) Tested by creating a simple geometry with one space, saving, then adding a second space and saving again. Opening the first file and re-adding the second space, and saving for a third time. Before the change, this process produced different internal IDs in the second and third save files. After this change the IDs were identical, as intended

bgschiller commented 3 years ago

This looks great, thanks @Mkellyeng !

Don't mind the failed build, it looks like our CI setup needs some attention.