Closed benfen closed 2 years ago
@benfen this merge request seems to have introduced an unintended style alteration in the color pick dialog. The popup no longer spans the entire screen but instead is cramped within the form from where it originates:
For small screen sizes this makes it hard to interact with the color picker.
And this also happens:
Can this be fixed by any chance?
I did some testing and I found what css causes this problem but I have no clue on how to fix it. See below for two css lines for the class vue-recycle-scroller__item-view that I disabled to remove this behaviour.
Note also that the old colour-picker had a 4x4 grid, which is now stretched to a 3x5 + 1 grid.
The window texture is also gone:
@Mathadon I'll look into that. Definitely related to swapping out the table library.
@Mathadon Fixes for the color picker modal are in PR - https://github.com/NREL/floorspace.js/pull/403
The texture option appears to be working as intended - the dropdown to choose texture only appears when the Mode
is set to Window to Wall Ratio
for the window.
findClosestEdge
function; modifying this function and thefacesContainingEdge
function sped up the function by about 2x