NREL / floris

A controls-oriented engineering wake model.
http://nrel.github.io/floris
BSD 3-Clause "New" or "Revised" License
217 stars 156 forks source link

Update UncertainFlorisModel to work with new Parallel framework #983

Closed paulf81 closed 2 months ago

paulf81 commented 2 months ago

Update UncertainFlorisModel to work with new Parallel framework

Note this PR replaces the outdated PR here: https://github.com/misi9170/floris/pull/1

The rework of the ParallelFlorisModel in #982 enabled an improved working of UncertainFlorisModel and ParallelFlorisModel. Previously ParallelFlorisModel would accept an UncertainFlorisModel and had special case handling to work with it. It has been discovered this code was not actually working the final result reflected a nominal result excluding the uncertain parameters. With the refactor it's more direct to simply have the UncertainFlorisModel accept aParallelFlorisModel (since the new version maintains a matched API to FlorisModel). This PR makes minor changes to the arguments and docstring of UncertainFlorisModel and specifically: