search

NREL / gbxml-to-openstudio

Releases of the OpenStudio CLI for Revit Systems Analysis.
5 stars 2 forks source link

Fix/systems analysis report/coil sizing detail mapper #105

Closed MatthewSteen closed 2 years ago

MatthewSteen commented 2 years ago

Error is caused by a new attribute/column Peak Load Type to Size On in the Coil Sizing Details table of the EnergyPlus SQL file added in EnergyPlus 9.3.0, which breaks the hard-coded indices in coil_sizing_detail_mapper.rb.

I remapped it using the Coil Sizing Details column headers from OpenStudio 3.4.0 (EnergyPlus 22.1.0) adding all the columns because some were not included in the map. Note, the System Analysis Report didn't render for me with OpenStudio 2.8.1 or 3.4.0.

MatthewSteen commented 2 years ago

We should decide where the System Analysis Report measure should live long term and which measures in this repo should stay/go to reduce redundancy (i.e. all the non-gbxml measures). I think there should be a single source of truth so there are two obvious options.

  1. Keep the repo focused on gbXML measures.
  2. Move development of the Systems Analysis Report measure here and rename openstudio-revit-measures or similar so Autodesk has a single source of truth too.