import_gbxml in OpenStudio 3.4.0 uses IDs instead of names

NREL / gbxml-to-openstudio

Releases of the OpenStudio CLI for Revit Systems Analysis.

5 stars 2 forks source link

import_gbxml in OpenStudio 3.4.0 uses IDs instead of names #108

Closed axelstudios closed 2 years ago

axelstudios commented 2 years ago

This primarily affects reporting output (eplustbl.html, SystemsAnalysisReport, etc). The names of objects in the idf, osm, and reports doesn't match the previous behavior and obscures the actual names, which makes filtering results in the reporting measure more difficult:

Previously behavior with OpenStudio 2.8.1:

Building Name was Project Name
Thermal Zone might have a name like RP-1

New behavior with OpenStudio 3.4.0:

Building Name is a gbxml ID like aim0013
Thermal Zone name is now a gbxml ID like aim0773

MatthewSteen commented 2 years ago

Might be related to #100 (#101). OS 3.4.0 now uses gbXML IDs for OS object names. https://github.com/NREL/OpenStudio/issues/4457

@anchapin you could consider working off of my workaround-openstudio-4457 branch after merging master in.

axelstudios commented 2 years ago

@MatthewSteen It's definitely similar and can probably be solved using the same approach, but #101 doesn't fix this unfortunately

MatthewSteen commented 2 years ago

From Noah on Slack...

looking at the duplicate names issue I've checked a couple things. The first is that gbXMLId (or whatever the additionalProperty is) was added to the import after this work was done. That said, it looks like Revit is enforcing unique names on spaces and zones (that's what I've checked) for gbXMLs produced for Systems analysis so we shouldn't run into the issue going forward. For now, we should be good but if the problem arises we can allocate time/stories to make changes to use IDs.