Closed eringold closed 9 months ago
Adds parsing of multiple YearSchedules with BeginDate and EndDate fields and translation into ScheduleRules.
Close https://github.com/NREL/gbxml-to-openstudio/issues/131, Jira revit 213603.
The Schedule element can have 1 or more YearSchedule with BeginDate and EndDate to tell when it takes effect. [x] However, the current measures only take the first year: https://github.com/NREL/gbxml-to-openstudio/blob/9868a5cb763ff6de1ffdf31a5aaabbbf973f3fc6/measures/advanced_import_gbxml/measure.rb#L325 [x] The measures then hardcode the full year range, regardless of the BeginDate and EndDate: https://github.com/NREL/gbxml-to-openstudio/blob/9868a5cb763ff6de1ffdf31a5aaabbbf973f3fc6/measures/advanced_import_gbxml/resources/os_lib_adv_import.rb#L831 [x] The existing logic that sets the schedule based on building type should be removed: https://github.com/NREL/gbxml-to-openstudio/blob/9868a5cb763ff6de1ffdf31a5aaabbbf973f3fc6/measures/advanced_import_gbxml/resources/os_lib_adv_import.rb#L869-L899
The Schedule element can have 1 or more YearSchedule with BeginDate and EndDate to tell when it takes effect.
[x] However, the current measures only take the first year: https://github.com/NREL/gbxml-to-openstudio/blob/9868a5cb763ff6de1ffdf31a5aaabbbf973f3fc6/measures/advanced_import_gbxml/measure.rb#L325
[x] The measures then hardcode the full year range, regardless of the BeginDate and EndDate: https://github.com/NREL/gbxml-to-openstudio/blob/9868a5cb763ff6de1ffdf31a5aaabbbf973f3fc6/measures/advanced_import_gbxml/resources/os_lib_adv_import.rb#L831
[x] The existing logic that sets the schedule based on building type should be removed: https://github.com/NREL/gbxml-to-openstudio/blob/9868a5cb763ff6de1ffdf31a5aaabbbf973f3fc6/measures/advanced_import_gbxml/resources/os_lib_adv_import.rb#L869-L899
Adds parsing of multiple YearSchedules with BeginDate and EndDate fields and translation into ScheduleRules.
Close https://github.com/NREL/gbxml-to-openstudio/issues/131, Jira revit 213603.