gdxpds 1.2.0 can't parse semicolon separated GAMSDIR

NREL / gdx-pandas

Python interface to read and write GAMS GDX files using pandas.DataFrames as the intermediate data format.

BSD 3-Clause "New" or "Revised" License

43 stars 15 forks source link

gdxpds 1.2.0 can't parse semicolon separated GAMSDIR #82

Closed jebob closed 3 years ago

jebob commented 4 years ago

Currently, a typical %GAMSDIR% in my organisation looks something like C:\GAMS\win64\25.1.3;C:\GAMS\win64\25.1.3\gbin;C:\GAMS\win64\25.1.3\apifiles\Java\api. This means __find_gams takes tries to find gams in the folder C:\GAMS\win64\25.1.3;C:\GAMS\win64\25.1.3\gbin;C:\GAMS\win64\25.1.3\apifiles\Java\api which doesn't exist.

One option is to validate the path before using it.

I'm digging into why this is but would it be possible to hotfix this or check which/where?

jebob commented 4 years ago

https://github.com/NREL/gdx-pandas/pull/83 solves my problem, would be happy to close this.