search

NREL / hercules

Hercules
https://nrel.github.io/hercules/
Apache License 2.0
3 stars 7 forks source link

Adding solar controller and replacing AMR-Wind standin with FLORIS standin in example 07 #104

Closed brookeslawski closed 5 months ago

brookeslawski commented 5 months ago

1. Solar controller

Implementing a simple PV plant controller that trims any PV plant power output above the setpoint at each timestep. This is similar to what pysam does. The "curtailment" is applied uniformly to the entire PV plant.

Requires an input power setpoint signal, which is read in through the input file field external_data_file.

In the future, this power setpoint might be calculated internally in hercules and this controller will need to be modified to handle that input.

2. FLORIS stand-in

The AMR-Wind stand-in was causing the errors shown below. MicrosoftTeams-image (1)

FLORIS was determined to be a better stand-in anyway, and was easy to implement, so the FLORIS stand-in replaced the AMR-Wind stand-in.

misi9170 commented 5 months ago

Hi @brookeslawski! I left a handful of small comments, but perhaps I'm a little confused about the files in the 07_floris_standin_and_solar_pysam. It seems that there is a bit of a mix in there of files that are needed to run this example, and files that maybe are just carry-overs from when it was 07_amr_wind_standin_and_solar_pysam, several of which I think are no longer used.

Did you mean to leave those in? Is the intention that the user could run the example with the AMR-Wind standin, as well as with the FLORIS standin?

brookeslawski commented 5 months ago

Hi @brookeslawski! I left a handful of small comments, but perhaps I'm a little confused about the files in the 07_floris_standin_and_solar_pysam. It seems that there is a bit of a mix in there of files that are needed to run this example, and files that maybe are just carry-overs from when it was 07_amr_wind_standin_and_solar_pysam, several of which I think are no longer used.

Did you mean to leave those in? Is the intention that the user could run the example with the AMR-Wind standin, as well as with the FLORIS standin?

Hi @misi9170 - Thank you for the review. I've deleted the amr_wind_standin files, which was just the hercules_runscript_amr_standin.py