search

NREL / hercules

Hercules
https://nrel.github.io/hercules/
Apache License 2.0
3 stars 7 forks source link

Improving indexing of solar weather file based on dt in input .yaml file #111

Closed brookeslawski closed 2 weeks ago

brookeslawski commented 1 month ago

This pull request improves the way that solar_pysam.py selects data from the input solar weather file. The input solar weather file contains timeseries weather data at a temporal resolution that may or may not be the same as dt in the input .yaml file. This pull request ensures that solar_pysam.py is selecting weather data at the correct timestamp. For example, if the input solar weather file contains data at every 0.5 second, but dt = 1.0 s in the .yaml file, the solar module will select data at every second after the timestamp of the first row of data.

If dt is not equal to or a multiple (>1) of the temporal resolution in the input solar weather file, a warning will print to the hercules log file.

This pull request does interpolate input data if dt is smaller than the temporal resolution in the input solar weather file. This interpolation should happen outside of hercules as part of pre-processing. An example of this pre-processing is included in example_case_folders/07_floris_standin_and_solar_pysam/read_solar_precursor_data.ipynb.

I have also improved the handling of timezones and added a warning that timezone must be included in the input solar weather file timestamps.

Also included are the input weather files from the ARM experiment and from the Flatirons campus, which were used for testing.

brookeslawski commented 1 month ago

All tests are passing locally. image

misi9170 commented 1 month ago

All tests are passing locally.

Thanks @brookeslawski ! See this pull request for attempts (which were ultimately unsuccessful) to get these failing tests on github to clear. For the time being, we'll just ensure the tests pass locally.

brookeslawski commented 3 weeks ago

Per Misha's suggestion, added a verbose flag in the SolarPySAM module to toggle on and off the print statements used for debugging. Re-ran tests and they all pass locally.