search

NREL / hercules

Hercules
https://nrel.github.io/hercules/
Apache License 2.0
3 stars 7 forks source link

simple_battery unit tests #64

Closed ZackTully closed 7 months ago

ZackTully commented 7 months ago

Unit tests for SimpleBattery module.

Resolves #53

ZackTully commented 7 months ago

@misi9170 Sure! I'll take a look at it later today.

misi9170 commented 7 months ago

It looks good to me, I'm just wondering why all the floris changes also show up as changed files for this pull request? Is it because of the Floris v4 update?

That's a bit strange... I'll look into that a little, thanks for pointing that out @genevievestarke

misi9170 commented 7 months ago

@ZackTully @genevievestarke Ok that issues with the comparison is fixed. I'm going to review the corresponding PR on WHOC and then should be able to merge both.

genevievestarke commented 7 months ago

Ok, great, sounds good!

misi9170 commented 7 months ago

@ZackTully Thanks for the updates; I'm going to go ahead and merge this and the companion on WHOC.