search

NREL / hercules

Hercules
https://nrel.github.io/hercules/
Apache License 2.0
3 stars 7 forks source link

Adding PV module unit tests and documentation #79

Closed brookeslawski closed 6 months ago

brookeslawski commented 6 months ago

Addressing Issues #54 and #67

This PR adds unit tests and documentation for the SolarPySAM module and corrects/improves some of the variable names.

brookeslawski commented 6 months ago

I believe it's best practice for the unit tests to be totally self-contained. At the moment, this test requires the json file in the example folder, which doesn't cause an errors but is not perfect. I'm working to eliminate the use of this file, but waiting for support from the PySAM team to do that.

brookeslawski commented 6 months ago

You'll notice that SimpleSolar is still in there - I'm going to do a separate PR for this change because it appears in other, older example folders and I want to meet with the PySAM developers to implement a default input before replacing SimpleSolar with SolarPySAM in all the example files.