search

NREL / hercules

Hercules
https://nrel.github.io/hercules/
Apache License 2.0
3 stars 7 forks source link

Citation file #86

Closed ZackTully closed 6 months ago

ZackTully commented 6 months ago

73

misi9170 commented 6 months ago

Just noting here that I think the citation button won't go into affect until develop is merged into main (because main is the default branch, see here). An option would be to point this PR at NREL:main instead, which should not create any complications with later merging develop into main (or if it does, they will be easy to manage). @genevievestarke any opinions on that?

EDIT: Scratch that suggestion, sorry. This branch was made from develop, so pointing this PR at main will also try to bring over all the other changes from develop. I'd say proceed with getting this merged into develop. Once that's done, we can either:

genevievestarke commented 6 months ago

Sounds good to me! I think it might be easier to push this file to main, and then merge back into develop?

misi9170 commented 6 months ago

Sounds good to me! I think it might be easier to push this file to main, and then merge back into develop?

Ok; I think to do that, the best way will be for me to check out this file on main; push directly to main; merge main into develop; and push develop. This PR will remain open during that process, but once that is done, I can "merge" this PR to show it's completion (although, at that point, there should be no difference between develop and this PR).

misi9170 commented 6 months ago

I've now directly pushed CITATION.cff to main ca4fcda, and then merged main back into develop f598a1a. To avoid mucking up the history, I'm closing this PR without merging, and will then close #73.