Refactor example 7 - Githubissues

NREL / hercules

Hercules

https://nrel.github.io/hercules/

Apache License 2.0

3 stars 7 forks source link

Refactor example 7 #87

Closed paulf81 closed 6 months ago

paulf81 commented 6 months ago

This pull request refactors example 7 as was done for example 6. Note the example has an issue with pysam I made need help debugging (@brookeslawski maybe I can ask your help here?)

Otherwise done so far:

Update sbatch file to new standard regarding clarity and logs -> outputs/
Add a new standard README file
Set up readme to be part of docs

Still to go:

[ ] Fix bug in example
[ ] Clean up example code where needed
[ ] Add example as another test in example CI?

brookeslawski commented 6 months ago

If the error you were getting was

  File "/Users/bstanisl/hercules-pysam/hercules/hercules/python_simulators/solar_pysam.py", line 63, in step
    system_model.value(k, v)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa3 in position 41: invalid start byte

then this is a bug that popped up in one of the develop updates, but I fixed it in my last PR, which I closed on Monday. I have fixed this error by changing KeyError to Exception and I'll commit my changes to this PR.

paulf81 commented 6 months ago

@misi9170 and @genevievestarke , @brookeslawski fixed the bug and so this is now ready for review