NREL / hive

HIVE™ is a mobility services research platform
https://nrelhive.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
22 stars 9 forks source link

Ndr/update link speed #200

Closed nreinicke closed 1 year ago

nreinicke commented 1 year ago

closes #26 by updating a link traversal with the current speed from the road network at the time of traversal.

this also touches almost all the test files since we have pre-commit installed now and since I updated one test, I had to recursively go through all the tests and fix them to get the pre-commit hooks to let me submit this.

robfitzgerald commented 1 year ago

this also touches almost all the test files since we have pre-commit installed now

i don't think i know the whole story here, so, maybe could you explicitly list the things i should be looking for in my review?

nreinicke commented 1 year ago

Yeah sorry I should have explained more. Since we added precommit, each time you edit a file, it runs the linter against it and requires a fix before it will allow you to check the code in. When writing tests for this update, I had to modify the mock lobster file which gets imported by almost all the test files and so it led to me having to tweak all of those files to satisfy the linter.

All that being said, you should be able to just look at the following three files:

nreinicke commented 1 year ago

Also, to be explicit about the substantive changes, I just modified the traverse function to take the road network into scope and then get the link speed from the network at the time of a single link traversal.