search

NREL / mappymatch

Pure-python package for map matching
http://mappymatch.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
58 stars 19 forks source link

Response to Issue #14 - Improving visualization of matches #100

Closed grahamwaters closed 2 years ago

grahamwaters commented 2 years ago

This adds a match score plot for analysis of geospatial points inside Match and Road objects.

Rowlando13 commented 2 years ago

I think there might be a couple typos or I am not understanding your PR. Issue #15 is about github actions. Also this just includes a jupyter notebook. Nick will have to weigh in, I think this belongs in the [NREL/Mappymaptch examples repo] (https://github.com/NREL/mappymatch-examples)

grahamwaters commented 2 years ago

I believe you may be correct about that. It was an added feature, so likely this would not live in the utils folder. Should I do a separate PR?

Rowlando13 commented 2 years ago

I changed the title and linked the correct issue. Upon looking at your code and the issue, I think this should be converted to .py . It looks like you wrote some functions to help improve visualizations. The .ipynb format confused me. So it would go somewhere in this repo. I defer to one of core maintainers as to where.

nreinicke commented 2 years ago

@Rowlando13 - thanks for updating to the correct issue.

@icehelmetminer - I agree that this new mapping feature should be reduced to a single function that we could put in the mappymatch.utils.plot sub module. The signature could look something like this:

def plot_match_distances(matches: MatchResult):
    # build and display plots here.
nreinicke commented 2 years ago

Closing as this has been picked up in #108