Closed grantbuster closed 2 years ago
physical limits are set here, just make sure the physical limit works with the dtype bitrange: https://github.com/NREL/nsrdb/blob/main/nsrdb/config/nsrdb_vars.csv
i changed the max to 10 but since the max value for a uint16 is 65535 the scale factor would need to be changed to 1000 right? if im interpreting this correctly the max value the var can take is max*scale_factor. Should we do max = 60 and scale = 1000 or max = 6 and scale = 10000?
Glad you checked! how about max=10 and scale=1e3? That works right? I think 1e-3 decimal precision is probably more than we can accurately know.
but this is less than the current config: 1.5 * 10000. am i misunderstanding how this works?
Yeah so the currently AOD can be represented as 1.4999 (=1e4 will allow that to be scaled as an integer with that precision), but I'm saying lets represent the max as 9.999 (=1e3 for integer precision).
ok sounds good!
Bug Description AOD goes above the previous limit (1.5?) during fires. We should up the AOD limit to 10. Make sure we check the bitrange.