search

NREL / nsrdb

This repository contains all of the methods for the NSRDB data processing pipeline.
https://nrel.github.io/nsrdb/
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

additonal flags for cli #37

Closed bnb32 closed 2 years ago

bnb32 commented 2 years ago

Might be nice to have flags just for pc, shading, and remap_pc instead of having to specify files also for when running python -m nsrdb.cli direct data-model?

Would need to add flags to cli.py and pass them to the data-model routine.

Not urgent at all though.

grantbuster commented 2 years ago

So I see this is a convenience vs. maintenance debate. It may be nice to have CLI flags for all available NSRDB options but this is a ton of extra code to pass through these options to all low level software modules. The factory kwargs is a generic way to add extra arguments specific to a run and to a dataset - it allows you to experiment with new features without having to write new code that passes options through lots of levels of software. Consider that we are only including these kwargs because we are experimenting with them - in the future they will all be True by default and we will not be using these flags for 99% of jobs.

bnb32 commented 2 years ago

Yeah this makes perfect sense. I figured they would all be true eventually.