search

NREL / nsrdb

NSRDB data processing pipeline. Includes satellite data assimilation, cloud property prediction and gap-filling, radiative transport modeling, and data collection.
https://nrel.github.io/nsrdb/
BSD 3-Clause "New" or "Revised" License
7 stars 0 forks source link

fixing str_replace call according to rename in rev #55

Closed bnb32 closed 1 year ago

bnb32 commented 1 year ago

@grantbuster The mlclouds tests seem to failing bc the production model was made with tensorflow=2.8. Should we update the model or pin tensorflow? Phygnn would also need to be pinned in that case, I think.

grantbuster commented 1 year ago

TF 2.8 is already pinned in mlclouds?

bnb32 commented 1 year ago

TF 2.8 is already pinned in mlclouds?

Oh yeah, you're right. I was able to reproduce the error with tf=2.8 and phygnn=current, and resolved the error with phygnn=0.0.14. So maybe it has to do with phygnn?

grantbuster commented 1 year ago

what version of phygnn was the mlclouds model produced with? fine to pin the phygnn version if that fixes things but that would surprise me because the phygnn requirements are pretty flexible.

bnb32 commented 1 year ago

It was produced with version 0.0.14 but I'd rather not pin this either.