search

NREL / nsrdb

This repository contains all of the methods for the NSRDB data processing pipeline.
https://nrel.github.io/nsrdb/
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

incorrect logic in collection? #56

Closed bnb32 closed 1 year ago

bnb32 commented 1 year ago

https://github.com/NREL/nsrdb/blob/36e9af32b61919573c4e98aff7e440920a85cf7b/nsrdb/file_handlers/collection.py#L168:L183

Malik discovered an edge case here (same code in sup3r): If row_loc or col_loc is [0] then not any() will be True even though a location was found. Should we change the not any() to not len() > 0?