search

NREL / openstudio-calibration-gem

Other
5 stars 5 forks source link

HardSizeHvac: undefined method `runSizingRun' #24

Closed juliobettamaalka closed 2 years ago

juliobettamaalka commented 3 years ago

https://github.com/NREL/openstudio-calibration-gem/blob/3b0a2b0b6adaaab13f16077f30c587acbd241204/lib/measures/HardSizeHvac/measure.rb#L75

As far as I understand, the method runSizingRun comes from 'resources/HVACSizing.Model' on line 70, right? if so, where can I find it?

eringold commented 3 years ago

@juliobettamaalka model.runSizingRun came from an older version of the OpenStudio Standards gem. That method was refactored to Standard::model_run_sizing_run

The measure should be updated to replace line 75 with:

std = Standard.build("90.1-2013")
std.model_run_sizing_run(model, Dir.pwd.to_s)
DavidGoldwasser commented 3 years ago

I have this on branch but want to add test before I merge it https://github.com/NREL/openstudio-calibration-gem/tree/hardsize_update