search

NREL / openstudio-calibration-gem

Other
5 stars 5 forks source link

version of measure with test is on common measure gem repo #25

Closed DavidGoldwasser closed 3 years ago

DavidGoldwasser commented 3 years ago

Copy of that measure with test is on common measure gem repo. Will maintain that copy. https://github.com/NREL/openstudio-common-measures-gem/tree/develop/lib/measures/ZoneReport

DavidGoldwasser commented 3 years ago

@tijcolem I tried to delete a measure and then merge to develop, but something didn't work in CI, this is the error I see

+ docker pull nrel/openstudio:3.1.1-alpha-ruby272-dev

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

script returned exit code 1

nllong commented 3 years ago

@tijcolem I tried to delete a measure and then merge to develop, but something didn't work in CI, this is the error I see

+ docker pull nrel/openstudio:3.1.1-alpha-ruby272-dev

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

script returned exit code 1

@tijcolem -- can you verify that docker is up-and-running?

nllong commented 3 years ago

@DavidGoldwasser -- can we upgrade this to extension gem 0.4.0? This version only supports Ruby 2.7.x, but it is the way of the future.

DavidGoldwasser commented 3 years ago

@nllong yes, getting this to newer extension gem and newer Ruby is great.

DavidGoldwasser commented 3 years ago

@nllong looks like I can't review my own change, back to you now. I did confirm that with my change to the argument method the measure.xm and readme.md both had expected data back in them.