search

NREL / openstudio-calibration-gem

Other
5 stars 5 forks source link

Adjust hours of operation #28

Closed DavidGoldwasser closed 3 years ago

DavidGoldwasser commented 3 years ago

Adding parametric schedule measures

DavidGoldwasser commented 3 years ago

@nllong in addition to adding two new parametric schedules measures this updates gemfile to match articulation gem that pulls from develop of ext gem and master of standards.

DavidGoldwasser commented 3 years ago

@tijcolem I just commented out the lines for ext and standards gem, I'll see if CI passes with that change.

DavidGoldwasser commented 3 years ago

@tijcolem commenting out those lines breaks the measure I was working on. It needs newer standards and ext gem until the CI is updated to be more current. I can revert the code I just made unless you have other suggestions.

tijcolem commented 3 years ago

@DavidGoldwasser It's okay to uncomment these to test and make sure things work with the latest changes in standards and ext gem. I guess my thought was to test and then wait until these have a tagged or release and then update here before merging.

tijcolem commented 3 years ago

@DavidGoldwasser The latest CI run is now configured to run the measures via cli embedded gems and bundler.

https://ci.commercialbuildings.dev/blue/organizations/jenkins/openstudio-calibration-gem/detail/PR-28/14/pipeline/

It'll produce to two sets of dashboards results. One for cli_embedded and one for cli_bundler.

openstudo via embedded gems https://ext-gem-dashboard.s3.amazonaws.com/openstudio-calibration-gem/PR-28/14/cli_embedded/dashboard/index.html

openstudio via bundled gems (what is defined in calibration gems) https://ext-gem-dashboard.s3.amazonaws.com/openstudio-calibration-gem/PR-28/14/cli_bundler/dashboard/index.html

I'll get these CI changes committed to openstudio_extension_gems so your other measures gems will use the same workflow.

For this PR run, it looks like you have one failing test in both cli and bundler.

tijcolem commented 3 years ago

@DavidGoldwasser So I re-ran this locally and uncommented the line in Gemfile and tests passed using bundler. So looks like there is a change between extension 0.4.0 vs develop. We'll need a new release of ext gems.

DavidGoldwasser commented 3 years ago

One test error which I expect is due to something out of sync with ext gem or standards gem, I'll run locally soon to confirm.

Failure: test_simple_model(Minitest::Result) [/srv/jenkins/git/openstudio-calibration-gem/PR-28/25/lib/measures/shift_hours_of_operation/tests/shift_hours_of_operation_test.rb:202]: --- expected +++ actual @@ -1 +1,3 @@ -"Success" +# encoding: ASCII-8BIT +# valid: true +"Fail"

DavidGoldwasser commented 3 years ago

@tijcolem @nllong @kflemin PR on first measure gem repo is through CI.

@nllong this is ready for release once it is merged.