search

NREL / openstudio-common-measures-gem

Other
7 stars 15 forks source link

adding XcelEDAReportingandQAQC measure #119

Closed tijcolem closed 1 year ago

tijcolem commented 2 years ago

Moving a measure from OpenStudio-measures to here to make it public and accessible on BCL.

See related pr https://github.com/NREL/OpenStudio-measures/pull/337

kflemin commented 2 years ago

@tijcolem, I think there are other Xcel measures in use...should we move them too? I'm thinking specifically of XcelEDATariffSelectionandModelSetup

tijcolem commented 2 years ago

@kflemin Yep, this would be a good time move the ones that are actively being used. I can moved that one over.

tijcolem commented 2 years ago

@kflemin it's added. let me know if there are others.

tijcolem commented 2 years ago

I need to find out why this failing. It looks like it's using another measure that might also need to be updated.

kflemin commented 1 year ago

@tijcolem, any idea on why this is failing? would be great to get this into develop. thanks!

tijcolem commented 1 year ago

@kflemin It's failing due to a dependent measure - generic_qaqc - that makes use of a deprecated emum fuel type value in OpenStudio. I'll see if I can fix.

tijcolem commented 1 year ago

@kflemin I added a GH Actions to this PR and provided those pass, we can merge. I'll disable Jenkins once I have the entire pipeline moved over (the html static result files that get pushed to S3 needs to be added).

tijcolem commented 1 year ago

@kflemin Tests are passing on GitHub Actions so I we can merge. We can dig into Jenkins if we want to, but if we are going to move over GitHub Actions probably not worth it.