search

NREL / openstudio-common-measures-gem

Other
7 stars 15 forks source link

add measure for ShadowCalculation #131

Closed MatthewSteen closed 1 year ago

MatthewSteen commented 1 year ago

Adds a measure for the ShadowCalculation class to mainly enable GPU-based shading calcs (Pixel Counting) for Revit work.

MatthewSteen commented 1 year ago

Test fails with a error fatal: detected dubious ownership in repository, which may be related to Docker. For example, see https://github.com/actions/runner-images/issues/6775#issuecomment-1410270956.

MatthewSteen commented 1 year ago

That error was fixed, thanks Tim. However, tests are failing for what looks like unrelated files from this PR.

MatthewSteen commented 1 year ago

@tijcolem what's the best fix for these failing tests here and on my other two PRs in this repo or is it a local issue?

Does the fix you committed here need to be included in docker-openstudio?

As far as I can tell, the test_with_openstudio.yml action is the same as our Jenkins CI and could be removed from this repo (it's not present in other measure repos). I can work on those improvements if I'm heading in the correct direction.