search

NREL / openstudio-common-measures-gem

Other
7 stars 15 forks source link

add measure for SimulationControl #133

Open MatthewSteen opened 1 year ago

MatthewSteen commented 1 year ago

Add a measure for the SimulationControl class, which was originally written in https://github.com/NREL/gbxml-to-openstudio/tree/193e50dfaa4f55ac9d9670a3821c374e88f04d0e/measures/set_simulation_control.

DavidGoldwasser commented 1 year ago

If we are going to add this need at least a test.rb file and a measure.xml

DavidGoldwasser commented 1 year ago

@MatthewSteen If Autodesk is going to use that and we needed in installer we can try to get this added in the next day or two

MatthewSteen commented 1 year ago

This is still a WIP that's not ready for review yet so I plan to add the files when I get back to it.

This is a longer term effort, so doesn't need to be in the next release, thanks.

MatthewSteen commented 1 year ago

@DavidGoldwasser this is ready for a review.

MatthewSteen commented 7 months ago

@DavidGoldwasser this is ready for a review.

MatthewSteen commented 2 months ago

@DavidGoldwasser this is ready for review. Test failure looks unrelated. Please add this to 0.10.0 if possible.