search

NREL / openstudio-common-measures-gem

Other
8 stars 15 forks source link

add customization for revit to openstudio results #134

Open MatthewSteen opened 1 year ago

MatthewSteen commented 1 year ago

Adds a small customization to the OpenStudio Results measure for Revit's Systems Analysis workflow from https://github.com/NREL/gbxml-to-openstudio/measures to reduce redundancy and establish a single source of truth. When/if this is merged, the duplicate OpenStudio Results measure can be removed from the gbxml-to-openstudio repo.

DavidGoldwasser commented 1 year ago

@MatthewSteen I like the idea of having single measure. The new revit argument does two things. Instead of having an argument to set unit it gets it from the OSW, it also adds the E+ eplustbl.

I propose a small modification to make these changes more generally applicable for other use cases.

  1. We already have a units choice argument that has IP and SI as choices. We can add a third option here that says Get Units from OSW File.
  2. the revit argument can be renamed Add EnergyPlus Detailed Report. It looks like the current revit argument is also turning the measure warnings section, but there is already a bool argument for that to be turned off.
DavidGoldwasser commented 1 year ago

@MatthewSteen I want to add in a test for the new argument option to use units from osw file. Can you proivde a sample OSW file with units. I thought I could generate that from OS App, but it doesn't look like it adds that

MatthewSteen commented 1 year ago

@DavidGoldwasser I'll work on adding a test for the new units choice, which is an OSRunner method that's not associated with the WorkflowJSON (OSW) class/object. Let me know if I'm missing something.

DavidGoldwasser commented 1 year ago

@MatthewSteen ahh assumed maybe it was in the OSW and then loaded here https://github.com/NREL/openstudio-common-measures-gem/blob/update/openstudio-results-for-revit/lib/measures/openstudio_results/tests/OpenStudioResults_Test.rb#L766

Or is the only way to populate the units with another runner method.

DavidGoldwasser commented 1 year ago

@MatthewSteen I didn't get to this last night, but I can review this afternoon.

MatthewSteen commented 1 year ago

@DavidGoldwasser I'm not ready for another review yet. I need to test the measure with the Revit Systems Analysis workflow before it's ready again. After I've done that I'll change this to ready for review again.

MatthewSteen commented 1 year ago

@DavidGoldwasser one of the customizations is in the report.html.erb file, which replaces the distributed javascript library sources with local copies in the /resources folder.

If this is ok with you, I'll commit those files and add code to replace the sources.

DavidGoldwasser commented 1 year ago

@MatthewSteen Yes, I'm fine with change to use local javascript files

MatthewSteen commented 1 year ago

@DavidGoldwasser this is ready for a review.

MatthewSteen commented 4 months ago

@DavidGoldwasser this is ready for review. Test failure looks unrelated. Please add this to 0.10.0 if possible.

MatthewSteen commented 1 day ago

@DavidGoldwasser I need to do some more testing to confirm that this works with the Autodesk workflow.