search

NREL / openstudio-common-measures-gem

Other
8 stars 15 forks source link

For all 14 tests to pass on generic qaqc 6 resource files had to be l… #144

Closed DavidGoldwasser closed 1 year ago

DavidGoldwasser commented 1 year ago

…eft on the measure

They can be removed from the measure after the ext gem shared resources should be updated, but those will be moved to standards before 3.7, so the update can be made there @mdahlhausen

DavidGoldwasser commented 1 year ago

@tijcolem do you have any ideas on why gem_env_report measure is now failing in CI? I don't think it should have interaction with changes I mad in qaqc measure on this branch. It runs fine when I do measure test on my local machine, but on CI I see this error

Failure: test_1(Minitest::Result) [:/ruby/2.7.0/json/common.rb:286]: Encoding::UndefinedConversionError: "\xE2" from ASCII-8BIT to UTF-8 :/ruby/2.7.0/json/common.rb:286:ingenerate' :/ruby/2.7.0/json/common.rb:286:in pretty_generate' /srv/jenkins/git/openstudio-common-measures-gem/PR-144/1/lib/measures/gem_env_report/resources/gem_env_info.rb:107:ingem_env_information' /srv/jenkins/git/openstudio-common-measures-gem/PR-144/1/lib/measures/gem_env_report/measure.rb:78:in run' /srv/jenkins/git/openstudio-common-measures-gem/PR-144/1/lib/measures/gem_env_report/tests/gem_env_report_Test.rb:72:intest_1'

line 107 of gem_env_info.rb looks like this pretty_result = JSON.pretty_generate(result)