NREL / openstudio-common-measures-gem

Other
7 stars 15 forks source link

Support OpenStudio 3.x #15

Closed nllong closed 4 years ago

DavidGoldwasser commented 4 years ago

@nllong this should be ready to merge. Passes local measure testing gem run for me.

nllong commented 4 years ago

@DavidGoldwasser -- can you look into this is failing?

DavidGoldwasser commented 4 years ago

@nllong I can't today. I think it is with the dependancies. I changed to openstudio-extension which in on ruby gems and has the more recent fixes needed by measures, do you think that is the issue. This will be hitting all of the measure gem repo pull requests.



Don't run Bundler as root. Bundler can ask for sudo if it is needed, and

installing your bundle as root will break this application for all non-root

users on this machine.

Fetching gem metadata from http://rubygems.org/.........

Fetching gem metadata from http://rubygems.org/.

Resolving dependencies...

Bundler could not find compatible versions for gem "parallel":

  In snapshot (Gemfile.lock):

    parallel (= 1.12.1)

  In Gemfile:

    openstudio-common-measures was resolved to 0.1.2, which depends on

      parallel (~> 1.12.0)

    openstudio-common-measures was resolved to 0.1.2, which depends on

      openstudio-extension (~> 0.2.1) was resolved to 0.2.1, which depends on

        parallel (~> 1.19.1)

Running `bundle update` will rebuild your snapshot from scratch, using only

the gems in your Gemfile, which may resolve the conflict.

script returned exit code 6
nllong commented 4 years ago

@DavidGoldwasser can you run your tests again locally? I ran rubocop on this and it touched a lot of files... thanks!

DavidGoldwasser commented 4 years ago

@nllong maybe in a week or two if I'm lucky, same for other repos.

DavidGoldwasser commented 4 years ago

@nllong I'm going to look at this today. Can you address the change request first to see if anything needs to come in from there

nllong commented 4 years ago

@nllong I'm going to look at this today. Can you address the change request first to see if anything needs to come in from there

You referring to juliens request?

nllong commented 4 years ago

@nllong I'm going to look at this today. Can you address the change request first to see if anything needs to come in from there

You referring to juliens request?

Okay, Julien's request should be satisfied. Versions are all in alignment.

nllong commented 4 years ago

image