NREL / openstudio-common-measures-gem

Other
8 stars 15 forks source link

initial setup for branch for OS 3.7 #157

Closed DavidGoldwasser closed 11 months ago

DavidGoldwasser commented 1 year ago

want to see if CI is setup to use 3.7-rc1 or if that still needs to be setup.

DavidGoldwasser commented 1 year ago

Only one error for XcelEDAReportingandQAQC, however I should locally run and look at OpenStudio Results HTML test outputs.

Failure: test_example_model(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/resources/CreateResults.rb:1007]: ArgumentError: invalid null reference Expected argument 0 of type std::string const &, but got NilClass nil in SWIG method 'Attribute' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/resources/CreateResults.rb:1007:ininitialize' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/resources/CreateResults.rb:1007:in new' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/resources/CreateResults.rb:1007:inblock (2 levels) in create_results' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/resources/CreateResults.rb:980:in each' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/resources/CreateResults.rb:980:inblock in create_results' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/resources/CreateResults.rb:976:in each' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/resources/CreateResults.rb:976:increate_results' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/measure.rb:136:in run' /srv/jenkins/git/openstudio-common-measures-gem/PR-157/2/lib/measures/XcelEDAReportingandQAQC/tests/XcelEDAReportingandQAQC_Test.rb:201:intest_example_model'`

DavidGoldwasser commented 1 year ago

Interesting outcome with OpenStudio results. While 9 pass on CI, 8 of 9 fail on local mac run. At least a few of them fail for at same line related to fuel type query https://github.com/NREL/openstudio-common-measures-gem/blob/develop/lib/measures/openstudio_results/resources/os_lib_reporting.rb#L567

Annual Overview section failed and was skipped because: Optional not initialized. Detail on error follows: /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/openstudio_results/resources/os_lib_reporting.rb:567:inget' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/openstudio_results/resources/os_lib_reporting.rb:567:in block (2 levels) in output_data_end_use_table' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-

DavidGoldwasser commented 11 months ago

Generic QAQC is failing as well, but similar to OpenStuidoResults the CI Dashboard doesn't pick it up. Hard to see on CI but can see on local run. Screen Shot 2023-11-28 at 9 56 11 AM

Issue filed on measure tester gem repo https://github.com/NREL/OpenStudio-measure-tester-gem/issues/71

DavidGoldwasser commented 11 months ago

Generic QAQC section failures does not propagate up to measure test failure. I can try to update that.

fail_b test has this error in Envelope R value test section

:/ruby/2.7.0/gems/openstudio-standards-0.5.0/lib/openstudio-standards/standards/Standards.SpaceType.rb:751:in space_type_get_construction_properties' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/resources/check_envelope_conductance.rb:164:inblock (3 levels) in check_envelope_conductance' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/resources/check_envelope_conductance.rb:155:in each' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/resources/check_envelope_conductance.rb:155:inblock (2 levels) in check_envelope_conductance' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/resources/check_envelope_conductance.rb:154:in each' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/resources/check_envelope_conductance.rb:154:inblock in check_envelope_conductance' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/resources/check_envelope_conductance.rb:150:in each' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/resources/check_envelope_conductance.rb:150:incheck_envelope_conductance' (eval):1:in block in run' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/measure.rb:335:ineval' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/measure.rb:335:in block in run' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/measure.rb:281:ineach' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/measure.rb:281:in run' /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/generic_qaqc/tests/measure_Test.rb:460:intest_GenericQAQC_fail_b' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest/test.rb:98:in block (3 levels) in run' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest/test.rb:195:incapture_exceptions' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest/test.rb:95:in block (2 levels) in run' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:272:intime_it' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest/test.rb:94:in block in run' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:367:inon_signal' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest/test.rb:211:in with_info_handler' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest/test.rb:93:inrun' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:1029:in run_one_method' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:341:inrun_one_method' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:328:in block (2 levels) in run' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:327:ineach' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:327:in block in run' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:367:inon_signal' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:354:in with_info_handler' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:326:inrun' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:164:in block in __run' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:164:inmap' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:164:in __run' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:141:inrun' :/ruby/2.7.0/gems/minitest-5.14.4/lib/minitest.rb:68:in `block in autorun'